Re: [PATCH] comctl32: Bump version to 6.0.

[Dmitry Timoshkov]

Nikolay Sivov  wrote:
> > > > An application that I have here checks comctl32.dll version information
> > > > and refuses to run, changing DLL version to 6.0 makes it run.
> >
> > ...
> > > So which one does it check, resources or DllGetVersion()?
> >
> > It checks the version information in the DLL resources
> > (GetFileVersionInfo).
>
> In that case I'd suggest to have it tested in staging first, at least until
> next stable release. It's not an ordinary dll version change because it's
> up to application to request it.

I have another suggestion:
We have a rule to revert patches that cause regressions, it would be
better IMO to accept this patch in main tree, test it, and if it will
cause regressions for a wide range of applications then revert it before
the code freeze.