Re: appdb/include application.php

[Tony Lambregts]

WineHQ wrote:
> ChangeSet ID:	30409
> CVSROOT:	/opt/cvs-commit
> Module name:	appdb
> Changes by:	[e-mail]	2006/12/07 21:38:27
>
> Modified files:
>    include        : application.php
>
> Log message:
>    Alexander Nicolaysen Sørnes 
>    Use $this instead of $oApp since this method is referring to its class
>
> Patch: http://cvs.winehq.org/patch.py?id=30409
>
> Old revision  New revision  Changes     Path
>  1.76          1.77          +2 -2       appdb/include/application.php
>
> Index: appdb/include/application.php
> diff -u -p appdb/include/application.php:1.76 appdb/include/application.php:1.77
> --- appdb/include/application.php:1.76	8 Dec 2006  3:38:27 -0000
> +++ appdb/include/application.php	8 Dec 2006  3:38:27 -0000
> @@ -345,12 +345,12 @@ class Application {
>              {
>              case "add":
>                  $sSubject =  "Submitted application accepted";
> -
>            $sMsg  = "The application you submitted (".$oApp->sName." ".$this->sName.") has been accepted by ".$_SESSION['current']->sRealname.".";
> -
>            $sMsg  = "The application you submitted (".$this->sName." ".$this->sName.") has been accepted by ".$_SESSION['current']->sRealname.".";

This is not right. this will print the application name twice. it should be
+                $sMsg  = "The application you submitted (".$this->sName.") has been accepted by .$_SESSION['current']->sRealname.".";
>              $sMsg .= "Administrators Responce:\n";
>          break;
>          case "reject":
>              $sSubject =  "Submitted application rejected";
> -
>            $sMsg  = "The application you submitted (".$oApp->sName." ".$this->sName.") has been rejected by ".$_SESSION['current']->sRealname.".";
> -
>            $sMsg  = "The application you submitted (".$this->sName." ".$this->sName.") has been rejected by ".$_SESSION['current']->sRealname.".";

same thing here
>              $sMsg .= "Clicking on the link in this email will allow you to modify and resubmit the application. ";
>              $sMsg .= "A link to your queue of applications and versions will also show up on the left hand side of the Appdb site once you have logged in. ";
>              $sMsg .= APPDB_ROOT."appsubmit.php?sub=view&apptype=application&appId=".$this->iAppId."\n";