On 5/31/21 1:10 PM, Dmitry Timoshkov wrote:
Dmitry Timoshkov dmitry@baikal.ru wrote:
Nikolay Sivov nsivov@codeweavers.com wrote:
Is save() part testable? Something close to what your application needs seems useful to have in tests. Does it load with one encoding, then changes it and saves?
The application creates XML in run-time, saves it and then loads from the file. There's a test for this already in test_createProcessingInstruction(), however testing encoding of the contents requires using some cyrillic instead of "test", so I decided to avoid that.
Do you need any other clarifications, or the patches might be accepted as is?
Let's have them as is. Would still be nice to have that saving test that shows that correct encoding is used, as a follow up patch.