Re: winequartz.drv: Add mouse events handling and stub window creation support. (take2)

[Pierre d'Herbemont]

On 20 nov. 06, at 20:34, Detlef Riekenberg wrote:
> On Mo, 2006-11-20 at 16:48 +0100, Pierre d'Herbemont wrote:
> > +/*
> > -
> > -
> > send_mouse_input
> > - */
> >
> > +static void send_mouse_input( HWND hwnd, DWORD flags, DWORD x,  
> > DWORD y,
> > -
> >                          DWORD data, DWORD time, DWORD  
> >
> > extra_info, UINT injected_flags )
> > +{
> > - POINT pt;
> > -
> > - pt.x = x;
> > - pt.y = y;
>
> POINT pt is never used for more than accessing pt.x and pt.y in this
> function, which is really useless, as both values are fn-parameters.
>
> Is there code waiting, that use pt?

You're right, I shouldn't use it. There are the remaining of the x11  
driver rip off.
> > +BOOL QDRV_CreateWindow( HWND hwnd, CREATESTRUCTA *cs, BOOL unicode )
> > - if (cs->cx > 65535)
> > - {
> > -
> >    ERR( "invalid window width %d\n", cs->cx );
> > -
> >    cs->cx = 50;
> > - }
>
> Setting the minimal or maximal size to 50 looks strange for me.
> Is this an leftover from debugging?

Indeed it is for debugging, because the metrics goes wrong as they  
are unimplemented, so to see the window it's better.
> > \ No newline at end of file
>
> This is easy to fix.

Why should a new line be at the end of the file? Is that a coding  
style issue?

Thanks,

Pierre.