On 5/14/21 4:04 PM, Rémi Bernon wrote:
Signed-off-by: Rémi Bernon rbernon@codeweavers.com
Supersedes: 205706-205709
Proper fix for test_GetRawInputBuffer failures in PATCH 2, the tentative fix from the previous version aren't actually making any different.
The issue was that the win test leaves the cursor in a different position, above the window that the test creates, when testbot makes several runs for various archs or locales, the first run has the cursor in a good place, but later runs are affected by the win test outcome.
When the cursor is moved, there may be some additional WM_INPUT messages generated from X11 events, if the cursor is above the window (or if it suddenly leaves the window) that aren't when it's not.
Making sure the window is not above the window
I meant the cursor, obviously.
FWIW I was confused that the testbot pattern page reports this failure only since 05/03. I guess maybe the way the tests are run have changed around that date.
I could reproduce the same failure when running the tests in winetest since Wine 6.7 at least (and it was probably the case even before), although it's not marked as failing there:
https://test.winehq.org/data/patterns.html#user32:input