Re: [PATCH 2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode

[Bruno Jesus]

On Thu, Jan 23, 2014 at 9:41 PM, Kai Blaschke  wrote:
> configure                     |  1 +
>  configure.ac                  |  1 +
>  dlls/bcrypt/tests/Makefile.in |  4 +++
>  dlls/bcrypt/tests/bcrypt.c    | 59
> +++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 65 insertions(+)

Hi, Kai.
> - status = pBCryptGetFipsAlgorithmMode(&result);
> - ok(!status, "expected status STATUS_SUCCESS(0), got 0x%08X\n", status);
> - ok(!result, "expected result FALSE, got %d\n", result);

If the value depends on a registry entry how can you be sure it will
always return 0? If the registry key is the only parameter required to
return in this function IMO you should read the registry here and
check against that instead of a fixed value.

Best wishes,
Bruno