2014-10-29 6:45 GMT-06:00 Michael Stefaniuc mstefani@redhat.com:
But the code still could look a lot better and some of the previous feedback wasn't addressed. There is an impedance mismatch between the code looking good for Alex and looking good for Wine.
As far as I know, I only rejected one of your suggestions for these 4 patches: Merging the simple_test and complex_test structs. The 3 simple tests are actually used as inputs for 8 tests each, for a total of 24 tests. Reformatting the 3 simple tests as complex tests would force me to manually input the 24 combinations into the complex_tests array. Is that really what Alexandre wants?
-Alex