Re: RFC: Richedit: Test Patch for EM_SETMARGINS

[James McKenzie]

On 1/16/11 10:24 AM, André Hentschel wrote:
> see http://test.winehq.org/data/

Will do.  I don't want to break Windows9x functionality though.
> > - /* Per http://msdn.microsoft.com/en-us/library/bb761649%(VS.85).asp
> >
> > if the lparam is
> > > > -
> > > >   EC_USEFONTINFO the Left and Right Margins should be set to a narrow width if the
> > > > -
> > > >   font has been set */
> > >
> > > They don't use permanent links I believe.
> >
> > Can I modify this to state the page name?
>
> remove the url, maybe better something like "msdn's documentation for functionxyz..."

Much better idea.
> - todo_wine {
> > > > -
> > > >    SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO, MAKELONG(EC_USEFONTINFO, EC_USEFONTINFO));
> > > > - }
> > >
> > > Hm.
> >
> > This is one of the test cases that was recommended and it appears to be the only one that 'works'.
>
> i bet Nikolay sighed about the curly brackets

Same style as used in the rest of the file.  I like curly braces on 
separate lines (I hope that is what you are referring to.)
> > > > - if (winetest_debug>  1) {
> > > >  test_WM_CHAR();
> > > >  test_EM_FINDTEXT();
> > > >  test_EM_GETLINE();
> > > >
> > > > @@ -7126,6 +7643,8 @@ START_TEST( editor )
> > > >     test_WM_GETDLGCODE();
> > > >     test_zoom();
> > > >     test_dialogmode();
> > > > - }
> > > > - test_em_setmargins();
> > >
> > > Why?
> > >
> > > Another question is how screen resolution affects that test.
> >
> > I will look at this as well.  I'll have to figure out how to change the resolution on the test bot and or my local copy of WindowsXP SP2 (not upgradable, no Internet connection to that system.
>
> to be clear: i guess it's about the dpi and not the resolution like 1024x768.

I interpreted it that way as well.  I have a system here set to 120 DPI 
and use small fonts for the default font setting.

James McKenzie