On Wed, 2003-09-24 at 16:53, Matthew Davison wrote:
I have recently noticed the large number of Stub DLLs being Added to wine with minimal functionality, for example Msi, MSHTML (they don't work for me in any case). These additions have not for the most part been accompanied with a new "native, builtin" entry in samples/config.
Annoying isn't it? The config file is not the right place to do this anyway, better to have it hardcoded into loader/loadorder.c IMHO, otherwise users will always forget to update their config.
Tracking this stuff in the source probably makes the most sense anyway.
I'm not fully sure of the semantics of this structure. I have a feeling specifying LOADORDER_DLL here (native) will cause wine to fail with the standard "dll not found" error if native isn't present rather than fall back. Arguably for these two DLLs that's actually what we want - at least the "dll not found" error is understandable by most users as opposed to some random stub crash/hang/whatever caused by missing functionality.
ChangeLog Force native MSI and MSHTML in the load order
Index: loader/loadorder.c =================================================================== RCS file: /home/wine/wine/loader/loadorder.c,v retrieving revision 1.66 diff -u -r1.66 loadorder.c --- loader/loadorder.c 5 Sep 2003 23:15:43 -0000 1.66 +++ loader/loadorder.c 25 Sep 2003 10:23:47 -0000 @@ -67,6 +67,8 @@ { "keyboard", { LOADORDER_BI, 0, 0 } }, { "krnl386.exe", { LOADORDER_BI, 0, 0 } }, { "mmsystem", { LOADORDER_BI, 0, 0 } }, + { "mshhtml", { LOADORDER_DLL,0, 0 } }, + { "msi", { LOADORDER_DLL,0, 0 } }, { "mouse", { LOADORDER_BI, 0, 0 } }, { "ntdll", { LOADORDER_BI, 0, 0 } }, { "odbc32", { LOADORDER_BI, 0, 0 } },