Re: [PATCH v2 2/2] services/tests: Retrieve monitor information when executed as service.

[Bernhard Übelacker]

Am 01.10.2018 um 19:42 schrieb Jacek Caban:
> Hi Bernhard,
>
> On 10/01/2018 07:41 PM, Bernhard Übelacker wrote:
> > Hello Jacek,
> > I am unsure about that point:
> > > > -
> > > >
> > > > +    service_ok(mi.dwFlags & MONITORINFOF_PRIMARY, "Unexpected
> > > > secondary monitor info.\n");
> > >
> > > Are those flags consistent between Windows version? It would be better
> > > to test all flags here.
> >
> > In /include/winuser.h there is just that flag and I found also no other
> > flags used inside the other display drivers.
> >
> > Also MSDN states just that only possible flag for the dwFlags member
> > of the tagMONITORINFO structure.
> >
> > Do you know of some other flag values or can we assume that point as checked?
>
> What I suggested is really using a comparison instead of bit and
> (mi.dwFlags == MONITORINFOF_PRIMARY). This way you can ensure that there
> are no more flags.
>
> Jacek

Thank you, now I got it.
Will send a new version soon.

Kind regards,
Bernhard