Re: [PATCH 01/10] vulkan: Add initial Wine vulkan header.

[Józef Kucia]

On Tue, Feb 20, 2018 at 7:29 AM, Roderick Colenbrander
 wrote:
> This file is directly generated from Vulkan's vk.xml. It contains Core and extension
> Vulkan types and functions.
> Note there are 4 lines of C++ style comments, but these directly come from the spec
> and appear in the regular headers as well.

Do we need comments in the generated file? It should be quite easy to
filter them out.
> +typedef enum VkAccessFlagBits {

Can we place curly brackets on a separate line also for enums? It's
already done this way for structs.
> - VK_ACCESS_INDIRECT_COMMAND_READ_BIT = 0x00000001,
> - VK_ACCESS_INDEX_READ_BIT = 0x00000002,
> - VK_ACCESS_VERTEX_ATTRIBUTE_READ_BIT = 0x00000004,
> - VK_ACCESS_UNIFORM_READ_BIT = 0x00000008,
> - VK_ACCESS_INPUT_ATTACHMENT_READ_BIT = 0x00000010,
> - VK_ACCESS_SHADER_READ_BIT = 0x00000020,
> - VK_ACCESS_SHADER_WRITE_BIT = 0x00000040,
> - VK_ACCESS_COLOR_ATTACHMENT_READ_BIT = 0x00000080,
> - VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT = 0x00000100,
> - VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT = 0x00000200,
> - VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT = 0x00000400,
> - VK_ACCESS_TRANSFER_READ_BIT = 0x00000800,
> - VK_ACCESS_TRANSFER_WRITE_BIT = 0x00001000,
> - VK_ACCESS_HOST_READ_BIT = 0x00002000,
> - VK_ACCESS_HOST_WRITE_BIT = 0x00004000,
> - VK_ACCESS_MEMORY_READ_BIT = 0x00008000,
> - VK_ACCESS_MEMORY_WRITE_BIT = 0x00010000,
> - VK_ACCESS_FLAG_BITS_MAX_ENUM = 0x7FFFFFFF,
>
> +} VkAccessFlagBits;