Re: [3/4] secur32/tests: Add a test for QueryCredentialsAttributes(SECPKG_CRED_ATTR_NAMES). Take 2.

[Nikolay Sivov]

On 12/12/2013 10:21, Dmitry Timoshkov wrote:
> Nikolay Sivov  wrote:
> > > - st = pQueryCredentialsAttributesA(&cred, SECPKG_CRED_ATTR_NAMES, &names);
> > > - ok(st == SEC_E_NO_CREDENTIALS || st == SEC_E_UNSUPPORTED_FUNCTION /* before Vista */, "expected SEC_E_NO_CREDENTIALS, got %08x\n", st);
> > > -
> >
> > Second possible return code should be broken(), otherwise your code
> > change in next patch won't make any effect on tests.
>
> SEC_E_UNSUPPORTED_FUNCTION is a perfectly valid error code, broken is not
> appropriate here. My next patch just changes Wine code to follow more recent
> Windows behaviour.

broken() is a way to mark it as undesired code for wine implementation, 
it doesn't necessary mean that something
changed significantly from error to success and such. Old return code 
will remain valid when running on windows.