Dmitry Timoshkov dmitry@baikal.ru writes:
Alexandre Julliard julliard@winehq.org wrote:
TIFF_VERSION_CLASSIC reflects the TIFF format itself, it's defined to 42, TIFF_VERSION_BIG introduced in 4.x defined to 43.
Unfortunately TIFFLIB_VERSION define reflects the date, not the real version. So for instance libtiff 3.9.7 has it defined to 20120922, 4.0.0 - 20111221, 4.0.1 - 20120218. I don't see a way to differentiate between 3.x and 4.x at compile time.
I see that this patch is now marked as 'pending'. Are my arguments not clear enough?
You shouldn't check the version, but the actual problem (i.e. the size of the offending type). Also please avoid unnecessary changes.
What changes do you consider as unnecessary?
For instance, changing tsize_t when the problem is with toff_t.