Signed-off-by: Giovanni Mascellani gmascellani@codeweavers.com -- Though notice a couple of minor items below.
On 17/11/21 18:04, Francisco Casas wrote:
@@ -1625,11 +1631,12 @@ static const struct intrinsic_function bool (*handler)(struct hlsl_ctx *ctx, const struct parse_initializer *params, struct vkd3d_shader_location loc); } intrinsic_functions[] = -{ +{ /* Note: these entries should be kept in alphabetical order. */
I would put this on a dedicated line.
+[pixel shader] +float4 main(uniform float4 u) : sv_target +{
- float a = round(u.r);
- int2 b = round(u.gb);
- float4 res = float4(b,a,u.a);
In general I'm not a fan of hard coding styles, but it makes sense to keep spaces after commas here too.
Thanks, Giovanni.