Re: [PATCH vkd3d v2] vkd3d-shader/hlsl: Explicitly specify the swizzle type for sm4 source registers.

[Zebediah Figura (she/her)]

On 11/11/21 13:14, Francisco Casas wrote:
> Some register types do not use a consistent swizzle type, so the
> sm4_swizzle_type() function is removed.
>
> The swizzle type now must be specified using the swizzle_type field.
> Signed-off-by: Francisco Casas

Sorry for the late review.

This omits the swizzle types for input semantics. Granted, we only have 
one so far, and due to other constraints we aren't actually capable of 
emitting it yet, but for the sake of correctness of architecture we 
should at least still put the path in.

(FWIW, the correct swizzle type for VKD3D_SM4_RT_PRIMID seems to be NONE).

While you're at it, could you please follow the code style used in the 
rest of vkd3d? Namely, space after the "if" keyword, and put the body on 
a new line.