On Fr, 2008-07-04 at 16:32 -0500, Alex Villacís Lasso wrote:
Resending. Please comment on this patch.
dlls/riched20/editor.c | 21 ++ dlls/riched20/editstr.h | 3 + dlls/riched20/paint.c | 36 ++- dlls/riched20/tests/editor.c | 794 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 844 insertions(+), 10 deletions(-)
I have no Idea about riched20, but your patch is far to huge.
- Do not submit dead code: * reportScrollRanges - Do not submit debugging code: * There is no need to flood the output with trace() Fine during development, but remove that before you create a Patch
- The implementation is enough for a seperate Patch - Please add only a basic Test in a Patch - Add more Tests in seperate Patches: * Every "DestroyWindow(hwndRichEdit)" is the end of a Patch
Thanks