Hi Paul,
Patches look generally good, just minor comments bellow.
On 6/21/21 2:11 PM, Paul Gofman wrote:
-/* ECMA-262 3rd Edition 12.2 */ +/* ECMA-262 10th Edition 13. TODO: HoistableDeclaration, ClassDeclaration */
None of IE versions supports class declarations, see browser compatibility:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes
diff --git a/dlls/mshtml/tests/es5.js b/dlls/mshtml/tests/es5.js index 03663917177..3467698e159 100644 --- a/dlls/mshtml/tests/es5.js +++ b/dlls/mshtml/tests/es5.js @@ -1318,6 +1318,18 @@ sync_test("declaration_let", function() { }
ok(a == 3, "a != 3");
- var except = false
- try
- {
eval('with({w:9}) let a = 3');
That's generally right, but I would suggest some less invasive statement than 'with' to make it cleaner what you're testing, say 'if (true)'.
Thanks,
Jacek