Re: [PATCH] ntdll: Mark NtCompareTokens as stub in spec file

[Zebediah Figura]

On 05/03/2019 12:20 PM, Vijay Kiran Kamuju wrote:
> This is helpful to the tests for comparing tokens created by
> NtFilterToken and CreateRestrictedToken.
> Also for checking DuplicateToken* functions, if it were implemented in
> wine, but windows exports it.
> I made a small test for NtFilterToken using NtCompareToken, its
> crashing in wine.

If you're using NtCompareToken() in tests, then leaving it a stub in the
specfile is not going to work. You'll end up calling the stub in Wine,
and you have no way of avoiding the subsequent crash. You should either
(ideally) implement the function completely, or make it into a stub
returning STATUS_NOT_IMPLEMENTED.