Re: [PATCH] ucrtbase: Added _sopen_dispatch/_wsopen_dispatch

[Huw Davies]

On 27 Oct 2016, at 17:17, Nikolay Sivov  wrote:
> diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c
> index 432d5c7..9097598 100644
> --- a/dlls/msvcrt/file.c
> +++ b/dlls/msvcrt/file.c
> @@ -2330,6 +2330,18 @@ int CDECL MSVCRT__wsopen( const MSVCRT_wchar_t *path, int oflags, int shflags, .
> }
>
> /*********************************************************************
> -
> -
>          _wsopen_dispatch (UCRTBASE.@)
> - */
>
> +int CDECL MSVCRT__wsopen_dispatch( const MSVCRT_wchar_t *path, int oflags, int shflags,
> - int pmode, int *filehandle, int secure)
>
> +{
> - if (secure)
> - FIXME("secure argument ignored.\n");
> -
> - return MSVCRT__wsopen_s( filehandle, path, oflags, shflags, pmode );
>
> +}

Wouldn’t it make more sense to have _wsopen() and _wsopen_s()
call _wsopen_dispatch() (and likewise for the char* version)?

Huw.