Re: [PATCH 1/2] server: Store async list in process object and use that to find async in cansel_async request.

[Jacek Caban]

On 30.11.2016 16:27, Alexandre Julliard wrote:
> Jacek Caban  writes:
> > @@ -614,6 +615,7 @@ static void process_destroy( struct object *obj )
> >  /* we can't have a thread remaining */
> >  assert( list_empty( &process->thread_list ));
> > - assert( list_empty( &process->asyncs ));
>
> I don't think that this is guaranteed, I believe that there can still be
> asyncs in the queues of shared files.

I think it is guaranteed. async object holds thread reference and thread
object holds process reference, so process object will not be destroyed
until all its asyncs are released. Asyncs in queues of shared objects
will keep process object alive (and they shouldn't), but it's not new
with my patch. Am I missing something?
> We'd probably need to clear them explicitly at process exit.

I agree that we should. I will send a new series implementing that. I
tested that with the attached patch (I can't send it to wine-patches yet
because it uses pipes in message mode).

Thanks,

Jacek