-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Alexandre Julliard wrote:
It would be much better to try the actual linking and see what happens.
Indeed, I was thinking on that myself... Why we just don't remove this (incorrect IMHO) file presence check and let autoconf do the check itself, which it already does as evidenced on the following snippet from configure.ac:
dnl Check for the presence of the library AC_CHECK_LIB(GL,glXCreateContext, OPENGL_LIBS="-lGL" ,, $X_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS)
Additionally, looking at the commit message that added the "test -e" check:
Changelog: Check for common broken nVidia+Mesa OpenGL library setups. http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1....
The current "test" check definitely does not ensure the system doesn't have this "broken" setup. As you said, it should be better to let autoconf do the check properly with AC_CHECK_LIB.
So here goes my latest patch which incorporates your suggestion (it just removes the broken check). I've tested it with both NVidia libraries (nvidia-glx and nvidia-glx-dev on Ubuntu 5.04) and Mesa "pure" libraries, and wine compiled with OpenGL on both setups. For tests, I've used:
make -C dlls/ddraw/tests/ test
Although I'm not sure this is the ideal test to check if OpenGL is working with Wine.
Best regards, - -- Anderson Lizardo