-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
I've already talked to Mark about this on #winehackers, just repeating it for the list: My remaining request with these tests is that I believe we should test the full set of inputs against the Ex and non-Ex versions and ideally reuse the test table (for base and ex, not for ipv4 and ipv6). That will tell us if there's any difference in the IP parsing part of the base and Ex functions. It'll also be interesting how the base function handles ports in the string, and, in case of ipv6, brackets around the IP.
Other than that two minor style issues: Change the subject of patch one (it only handles RtlIpv4StringToAddressEx), and you still have different levels of indentation in the line continuations of some ok() statements.
Cheers, Stefan
Am 2015-02-15 um 18:02 schrieb Mark Jansen:
Add test for RtlIpv4StringToAddressEx
--- dlls/ntdll/tests/rtl.c | 101 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+)