22 Apr
2019
22 Apr
'19
8:36 p.m.
On 4/22/19 1:06 PM, Damjan Jovanovic wrote:
On Mon, Apr 22, 2019 at 7:51 PM Zebediah Figura <z.figura12@gmail.com mailto:z.figura12@gmail.com> wrote:
On 04/22/2019 02:38 AM, Damjan Jovanovic wrote: > Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com <mailto:damjan.jov@gmail.com>> > --- > dlls/qcap/tests/audiorecord.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > Thanks for finding the leak. "filter" can never be NULL at that point, and we also want to test that we really are releasing the last reference. I've sent an updated patch that addresses these.Pleasure. It can be NULL, if IMoniker_BindToObject() fails.
IMoniker::BindToObject() shouldn't fail; that's checked above.