Re: better user messages

[Ove Kaaven]

On Sun, 19 May 2002, Francois Gouget wrote:
> On Sun, 19 May 2002, Andreas Mohr wrote:
> Index: dlls/gdi/freetype.c
>
> RCS file: /home/wine/wine/dlls/gdi/freetype.c,v
> retrieving revision 1.13
> diff -u -r1.13 freetype.c
> --- dlls/gdi/freetype.c	4 Apr 2002 15:30:29 -0000	1.13
> +++ dlls/gdi/freetype.c	19 May 2002 21:14:36 -0000
> @@ -452,9 +452,9 @@
>      ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0);
>      if(!ft_handle) {
>          WINE_MESSAGE(
> -
>  "Wine cannot find the FreeType font library.  To enable Wine to\n"
> -
>  "use TrueType fonts please install a version of FreeType greater than\n"
> -
>  "or equal to 2.0.5.\n"
> -
>  "Wine could not find the FreeType font library.  To enable Wine to\n"
> -
>  "use TrueType fonts please install a version of FreeType\n"
> -
>  "(plus devel/header file package) greater than or equal to 2.0.5.\n"
>  "http://www.freetype.org\n");
> return FALSE;
>    }
> Index: dlls/wineps/truetype.c
>
> RCS file: /home/wine/wine/dlls/wineps/truetype.c,v
> retrieving revision 1.15
> diff -u -r1.15 truetype.c
> --- dlls/wineps/truetype.c	3 Apr 2002 20:02:39 -0000	1.15
> +++ dlls/wineps/truetype.c	19 May 2002 21:14:37 -0000
> @@ -593,9 +593,9 @@
>      ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0);
>      if(!ft_handle) {
>          WINE_MESSAGE(
> -
>  "Wine cannot find the FreeType font library.  To enable Wine to\n"
> -
>  "use TrueType fonts please install a version of FreeType greater than\n"
> -
>  "or equal to 2.0.5.\n"
> -
>  "Wine could not find the FreeType font library.  To enable Wine to\n"
> -
>  "use TrueType fonts please install a version of FreeType\n"
> -
>  "(plus devel/header file package) greater than or equal to 2.0.5.\n"
>  "http://www.freetype.org\n");
> return TRUE;
>    }
>
> I disagree with this bit. This is printed by the Wine binary and the
> development libraries and headers are not needed for running Wine. Such
> a message should instead be printed by the configure script if it
> detects that FreeType libraries or headers are missing.

Actually, the development libraries *are* needed, though the headers are
not. This is because the dlopen tries to load "libfreetype.so", NOT
"libfreetype.so.6". And, at least on Debian, only the dev package provides
the libfreetype.so symlink, the library package itself only contains
libfreetype.so.6. (This issue is Debian bug #146136.)