Re: [PATCH resend3 2/2] kernel32: Reimplement GetMaximumProcessorCount on top of SystemCpuInformation

[Alex Henrie]

On Fri, Apr 30, 2021 at 8:18 AM Alexandre Julliard  wrote:
> Alex Henrie  writes:
> > @@ -629,9 +630,13 @@ DWORD WINAPI GetActiveProcessorCount(WORD group)
> >   */
> >  DWORD WINAPI GetMaximumProcessorCount(WORD group)
> >  {
> > - DWORD cpus = system_info.NumberOfProcessors;
> > - DWORD cpus = cpu_info.MaximumCpus;
> > -
> > - if (group == ALL_PROCESSOR_GROUPS)
> > -
> >    TRACE("(0x%x): returning %u\n", group, cpus);
> > - else
> > -
> >    FIXME("(0x%x): processor groups not supported, returning %u\n", group, cpus);
>
> That doesn't seem much better than the previous stub. It shouldn't be
> hard to implement these functions correctly now that we support
> GetLogicalProcessorInformationEx().

Sorry for not responding sooner; Gmail put your last two messages into
the spam folder and I didn't notice until Friday. Thank you for the
feedback. I will send new patches shortly.

-Alex