Re: [PATCH 2/2] vbscript/tests: Test lack of newline parsing before End statements.

[Jacek Caban]

Hi Gabriel,

On 9/5/19 2:48 PM, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu
>
> dlls/vbscript/tests/run.c | 99 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 99 insertions(+)
>
> diff --git a/dlls/vbscript/tests/run.c b/dlls/vbscript/tests/run.c
> index 15a8f10..87540a3 100644
> --- a/dlls/vbscript/tests/run.c
> +++ b/dlls/vbscript/tests/run.c
> @@ -2077,6 +2077,104 @@ static void test_gc(void)
>       IActiveScriptParse_Release(parser);
>   }
>
> +static void test_end_parse_without_nl(void)
> +{

How calling it test_parse_errors() with an intention of adding more 
parser errors to the array in the future?
> - static const char *invalid[] =
> - {
> -
>    /* If...End If */
> -
>    "If 0 > 1 Then\n"
> -
>    "    x = 0 End If\n",
> -
> -
>    /* While...End While */
> -
>    "While False\n"
> -
>    "    x = 0 End While\n",
> -
> -
>    /* While...Wend */
> -
>    "While False\n"
> -
>    "    x = 0 Wend\n",
> -
> -
>    /* Do While...Loop */
> -
>    "Do While False\n"
> -
>    "    x = 0 Loop\n",
> -
> -
>    /* Do Until...Loop */
> -
>    "Do Until True\n"
> -
>    "    x = 0 Loop\n",
> -
> -
>    /* Do...Loop While */
> -
>    "Do\n"
> -
>    "    x = 0 Loop While False\n",
> -
> -
>    /* Do...Loop Until */
> -
>    "Do\n"
> -
>    "    x = 0 Loop Until True\n",
> -
> -
>    /* Select...End Select */
> -
>    "x = False\n"
> -
>    "Select Case 42\n"
> -
>    "    Case 0\n"
> -
>    "        Call ok(False, \"unexpected case\")\n"
> -
>    "    Case 42\n"
> -
>    "        x = True End Select\n"
> -
>    "Call ok(x, \"wrong case\")\n",
> -
> -
>    /* Class...End Class  (empty) */
> -
>    "Class C End Class"
> - };
> - static const char *valid[] =
> - {

Please add tests that are expected to parse correctly to lang.vbs instead.

Thanks,

Jacek