21 Oct
2021
21 Oct
'21
2:19 p.m.
On Fri, Oct 15, 2021 at 10:47 PM Zebediah Figura (she/her) zfigura@codeweavers.com wrote:
Signed-off-by: Zebediah Figura zfigura@codeweavers.com
Although with the comment that it'd be nice to see some specific tests for these. I manually verified that this logic holds for three of the four places where we currently use add_implicit_conversion (viz. return values, assignments, and constructors); it doesn't hold for the fourth (the argument to Load) but that's probably not worth fixing.
Right, that seems to be a quirk that we probably don't want to replicate unless really necessary.
Also, yes, tests are always welcome.