Am Dienstag, 24. Mai 2005 21:40 schrieb Juan Lang:
--- Stefan Dösinger stefandoesinger@gmx.at wrote:
Checking against This->pidlRoot makes writing work.
<snip>
Is the attached patch correct?
That appears as if it would work. Although I must say my curiosity isn't quite satisfied. There's the comment in shlfldr_fs.c about dwAttributes, saying it should be used. And yet it's never initialized.
So it seems to me you could remove dwAttributes and the bad comment next to it, or you could:
- initialize it in Initialize and InitializeEx, using
SHELL32_GetItemAttributes with This->pidlRoot
- use This->dwAttributes in fnGetAttributesOf when cidl == 0
The latter way would be more performant perhaps.
That sounds right for me. Any suggestions to the following patch? Now the same thing for the other shfldr_s, right? shfldr_desktop.c, shfldr_mycomp.c and shfldr_unixfs.c
Stefan