Piotr Caban piotr.caban@gmail.com wrote:
v2:
- only patch 2 was changed (fixed detection when message should be
generated)
If only the patch 2 was changed that means that the tests don't really cover the implementation. That rises the questions: how the logic in the patch 2 was actually discovered, and what else is missing in the tests and the implementation?
The tests are not covering all combinations of flags passed to SetWindowPos (and I think there's no need for that). An example of test that will fail with first version of patch is added in patch 2.
Anyway I'll add few more tests for completeness.
How about user interactions? For instance when a user drags a window holding mouse button (without releasing it) over its caption? What about capture/activation/focus/thread attach states?