Re: [PATCH 2/2] winealsa.drv: send MIDI events to port subscribers

[Jacek Konieczny]

Hi Andrew,

Thank you for your review.
> > -
> >        snd_seq_ev_set_dest(&event, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> > -
> >        snd_seq_ev_set_dest(&event, SND_SEQ_ADDRESS_SUBSCRIBERS, 0);
>
> It looks like using snd_seq_ev_set_subs() might be a better fit here.

Indeed. I missed this shortcut.
> > @@ -1047,8 +1047,7 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize)
> >    snd_seq_ev_clear(&event);
> >    snd_seq_ev_set_direct(&event);
> >    snd_seq_ev_set_source(&event, port_out);
> > - snd_seq_ev_set_dest(&event, MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> > - TRACE("destination %d:%d\n", MidiOutDev[wDevID].addr.client, MidiOutDev[wDevID].addr.port);
> > -
> >    snd_seq_ev_set_dest(&event, SND_SEQ_ADDRESS_SUBSCRIBERS, 0);
>
> Same here, obviously.

yes.
> Also, in both patches, please try to match surrounding tab-style. I
> know it's already a mess.

It is. I looked at that once again and I give up. That mix of tabs and
spaces in the original code makes not sense to me :-)
> Or, if you prefer, I can fix it up and
> resend with your sign-off. Up to you.

That would be great. Will you change those snd_seq_ev_set_dest() to
snd_seq_ev_set_subs() too?

Greets,
Jacek