Re: [PATCH 3/6] COMDLG32: printdlg: check hook pointer (resend 3)

[Dmitry Timoshkov]

"Vitaly Lipatov"  wrote:
> --- dlls/commdlg/printdlg.c 11 Jan 2006 11:37:03 -0000 1.100
> +++ dlls/comdlg32/printdlg.c 24 Feb 2006 17:47:53 -0000

The way you've generated this patch looks pretty strange.
>  /* Call user paint hook if enable */
>  if (pda->dlga->Flags & PSD_ENABLEPAGEPAINTHOOK)
> -
>    if (pda->dlga->lpfnPagePaintHook(hwndDlg, uMsg, wParam, lParam))
> -
>    if (pda->dlga->lpfnPagePaintHook && pda->dlga->lpfnPagePaintHook(hwndDlg, uMsg, wParam, lParam))

You have to add the checks existing in PageSetupDlgA to PageSetupDlgW instead.

Also, in order to increase the probability of your patches to be included
should either point to existing bug that each of your patches fix, or/and
add a test case which doesn't pass without your patch and does with it.