Re: dlls/dinput/effect_linuxinput.c: Check return value of 'write'. (bug # 16413)

[James McKenzie]

Vitaliy Margolen wrote:
> titon barua wrote:
> >  /* we don't care about the success or failure of this call */
> > - write(*(This->fd), &event, sizeof(event));
> > - /* print errors if they occur */
> > - if (write(*(This->fd), &event, sizeof(event)) == -1) perror ( NULL );
>
> What's the point of your patch? What part of the comment isn't clear to you?
> Also don't use perror. Wine has ERR(), WARN(), TRACE() macros for that.

How about this:

Titon, this code does not need to be 'fixed' as it works the way it is 
supposed to.

Please remove this code and resubmit.

I was uncertain of what Titon was trying to fix so I looked up perror 
and it is not needed at this point and introduces uncertainty into the code.

James McKenzie