Re: [PATCH 1/2] xaudio2: Fix support for FAudio 19.06 and newer

[Alexandre Julliard]

[e-mail] writes:
> diff --git a/dlls/xaudio2_7/x3daudio.c b/dlls/xaudio2_7/x3daudio.c
> index ee3367e092..f08a425ca1 100644
> --- a/dlls/xaudio2_7/x3daudio.c
> +++ b/dlls/xaudio2_7/x3daudio.c
> @@ -51,8 +51,12 @@ HRESULT CDECL X3DAudioInitialize(UINT32 chanmask, float speedofsound,
>          X3DAUDIO_HANDLE handle)
>  {
>      TRACE("0x%x, %f, %p\n", chanmask, speedofsound, handle);
> +#if FAUDIO_ABI_VERSION >= 1
> - return F3DAudioInitialize8(chanmask, speedofsound, handle);
>
> +#else
>      F3DAudioInitialize(chanmask, speedofsound, handle);
>      return S_OK;
> +#endif

Was it really necessary to break binary compatibility so soon, and force
us to maintain ugly ifdefs and multiple builds of the library?  It looks
like it wouldn't be hard to avoid it.