Re: [PATCH] winealsa: snd_card_get_name uses strdup (Valgrind).

[Michael Stefaniuc]

Lauri Kenttä wrote:
> On 2012-02-01 17:00, Christian Costa wrote:
> > In that case you don't need the if (!err) condition to free the buffer
> > otherwise you leak the string return by strdup.
>
> Yeah, I didn't think this through and screwed up. :P
>
> I also noticed now that Jörg Höhle already deemed this strdup solution
> ugly in his previous try. Luckily Michael Stefaniuc sent a finer patch
> #83376.

Still not good enough. But at least we forced Alexandre to fix it himself ;)

bye
    michael