Am 2011-01-11 17:03, schrieb Juan Lang:
Tests must pass with every commit. In general, I prefer to see tests first, with failing tests marked todo_wine. Then the second patch, with implementation, removes the todo_wines. In this case adding todo_wine might be more trouble than it's worth, so I'd do them in the reverse order. I'll comment on your try 2 again shortly, though.
Sorry for the added blankline. I'll make both to a same-named try3 shortly.