On Thursday 08 January 2009 11:22:59 Alexandre Julliard wrote:
This test is there to show that the prototype of StringTableLookUpStringEx is broken; the last parameter is treated as an integer instead of a pointer and this notation serves to document that fact. But I can see how this will repeatedly trigger janitorial scripts, so I do not object to this patch going in.
Where does the prototype come from? AFAICS it's not in the PSDK. Maybe it's just wrong.
I don't know where the prototype came from, there was a stub there already which entered Wine with commit 8196e2d0d0dbd04325201e14d95f88cad3cfd00f.
So we might as well change the prototype, given its demonstrated behavior.
-Hans