Re: [PATCH] wineps.drv: Remove duplicate condition in PSDRV_SelectFont().

[Huw Davies]

On Wed, Sep 04, 2019 at 08:41:43PM +0300, Andrey Gusev wrote:
> Signed-off-by: Andrey Gusev
>
> dlls/wineps.drv/font.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/dlls/wineps.drv/font.c b/dlls/wineps.drv/font.c
> index d6e330159c..88c2777f87 100644
> --- a/dlls/wineps.drv/font.c
> +++ b/dlls/wineps.drv/font.c
> @@ -75,9 +75,7 @@ HFONT CDECL PSDRV_SelectFont( PHYSDEV dev, HFONT hfont, UINT *aa_flags )
>        strcpy(FaceName, "Symbol");
>        break;
>    }
> -
>
> }
> -
>
> if(FaceName[0] == '\0') {
>     switch(lf.lfPitchAndFamily & 0x0f) {
> case VARIABLE_PITCH:
>   strcpy(FaceName, "Times");

You can see that this isn't right by looking at the first
line of the hunk - FaceName may have changed between the
two tests.

Huw.