Hi,
a few days ago I found a bug in ole32/compobj.c where we did something like:
if ( foo & FLAG) .... where FLAG=0
This 'inspired' me to check for more of these kind of checks.
One that I already found is in dlls/dplayx/dplay.c
We are checking for DPSET_REMOTE (which is zero) where we should have checked for !DPSET_LOCAL or something alike.
Is it worthwhile to set up a Janitorial task for this or are these plain bugs? On the one hand it will be hard to find these and you have to know the code of course.
Cheers,
Paul.