Re: Start: Convert start to Unicode.

[Anatoly Lyutin]

Dmitry Timoshkov wrote:
> "Anatoly Lyutin"  wrote:
> > -/**
> > +WINE_DEFAULT_DEBUG_CHANNEL(start);
> > -
> >
> > +/*
>
> All these changes /** -> /* make the diff larger, and are not really
> necessary.

I have considered it in the new version.
> > Output given message to stdout without formatting.
> > */
> > -static void output(const char *message)
> > +static void output(const WCHAR *message)
> > {
> >  DWORD count;
> > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message,
> >
> > strlen(message), &count, NULL);
> > - DWORD   res;
> > - int    wlen = strlenW(message);
>
> Once you change your editor settings to use natural 8 spaces for a tab 
> you will
> see how ugly the formatting in your new code is.

I am sorry. I forgot that  in the start.c uses natural 8 spaces for a 
tab. Fixed.
> > -static void fatal_error(const char *msg, DWORD error_code)
> > +static void fatal_error(const WCHAR *msg, DWORD error_code)
>
> fatal_error() is not called with strings outside of ASCII charset, so
> there is no much point in converting it to unicode. It only makes your
> patch full of controversial changes. IMHO fatal_error() should be removed
> altogether, and replaced by proper error handling instead.

I think that it is the question of time. For example In the future these 
messages will be probably deduced in the Korean (or Japanese or etc)  
language.
But what proper error handling do you mean?Should I use a FIXME, ERR and 
so on?
I will resend my patch.