4 Jul
2022
4 Jul
'22
6:50 p.m.
On Mon Jul 4 18:50:19 2022 +0000, Alexandre Julliard wrote:
This is breaking a bunch of tests here:
tools/runtest -q -P wine -T . -M mmdevapi.dll -p dlls/mmdevapi/tests/mmdevapi_test.exe capture && touch dlls/mmdevapi/tests/capture.ok capture.c:259: Test failed: GetNextPacketSize 480 vs. GetDevicePeriod 36176 make: *** [Makefile:68094: dlls/mmdevapi/tests/capture.ok] Error 1 tools/runtest -q -P wine -T . -M mmdevapi.dll -p dlls/mmdevapi/tests/mmdevapi_test.exe render && touch dlls/mmdevapi/tests/render.ok render.c:427: Test failed: Latency < default period, delta -1022376220us (30d40 vs 746573646165485f) render.c:815: Test failed: Expected 10ms default period: 1634027615 render.c:831: Test failed: GetBuffer failed: 88890006 render.c:832: Test failed: NULL buffer returned wine: Unhandled page fault on read access to 00000000 at address 0040B3F7 (thread 015c), starting debugger... tools/runtest -q -P wine -T . -M mmdevapi.dll -p dlls/mmdevapi/tests/mmdevapi_test.exe spatialaudio && touch dlls/mmdevapi/tests/spatialaudio.ok spatialaudio.c:163: Test failed: Failed to activate spatial audio stream: 0x8007000e wine: Unhandled page fault on read access to 00000000 at address 00416955 (thread 0188), starting debugger...
Seems to be caused by allowing comparisons to a blank (`pulse_name[0] == 0`), I'm not completely sure why that would be an issue, especially with `pulse_get_prop_value` not doing that kind of test either, but adding the test fixes it, so I'll re-submit patches with this additional check. Sorry.