Re: [PATCH 3/9] d2d1: Stub ID2D1Factory1

[Nikolay Sivov]

On 21.11.2017 11:41, Lucian Poston wrote:
> - ID2D1Factory ID2D1Factory_iface;
> - ID2D1Factory1 ID2D1Factory_iface;

Variable name should also be renamed.
>  if (IsEqualGUID(iid, &IID_ID2D1Factory)
> -
>        || IsEqualGUID(iid, &IID_ID2D1Factory1)
>        || IsEqualGUID(iid, &IID_IUnknown))

This is usually ordered differently, newer then older.
> - if (FAILED(hr = d2d_rectangle_geometry_init(object, iface, rect)))
> - if (FAILED(hr = d2d_rectangle_geometry_init(object, (ID2D1Factory *)iface, rect)))

I think it's fine to fix casts like that in the same patch.
> - d2d_factory1_ID2D1Factory1_CreateStrokeStyle,
> - d2d_factory1_ID2D1Factory1_CreatePathGeometry,
> - d2d_factory1_ID2D1Factory1_CreateDrawingStateBlock,

I think you can remove middle part.