Re: [PATCH 3/8] d3drm: Implement IDirect3DRMDevice::CreateDeviceFromClipper.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-08-06 um 00:49 schrieb Aaryaman Vasishta:> +
IDirect3DRMDevice *device1; ... hr =
> - IDirect3DRMDevice *device1;
>
> ...
>      hr = IDirect3DRM_CreateDeviceFromClipper(d3drm1, clipper, &driver, 0, 0, &device1);
> - todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %x.\n", hr);
> - if (SUCCEEDED(hr))
> -
>    IDirect3DRMDevice_Release(device1);
> - ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %x.\n", hr);
> - ok(device1 == NULL, "Expected device returned == NULL, got %p.\n", device1);

Set device1 = (IDirect3DRMDevice *)0xdeadbeef before calling
CreateDeviceFromClipper, otherwise the device == NULL check isn't worth
much at the end. (You don't know if its NULL because
IDirect3DRM::CreateDeviceFromClipper set it to NULL or because it
happened to randomly contain NULL at the start of the function.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVw1NZAAoJEN0/YqbEcdMwSkcP/1NMXYG2m/OkDgVhrAg3kLB3
RRu4egHLkAPpxx9Ms0iAqfl9NtbhtlQpFBjOdwmdElOQbjRZFVpU5pUhFQO4jgbo
ywlrvkXYJvmsYWjMTzNFKM0vZaNO6uRQK/pg/QWwqCW+xlunCyHa8vWLzu4u34sB
FqGfjOeS/FoQkH2IYnFjpSV12Org9wJC+GVwqw8h1yfgiW3lKaCgRUcA0pRNgC5o
l4OlkLhnAC9EqvdSHDgW+A9UkslVDMZq7iq5XFNCasRKqPixCoEsXXu8LH3JakCI
3WOn0z8bgelcLl8Z6xr4dXO5iKvw2Ff1DxKPnmQrykzY2E4OQkZdjqMznXKNqq3g
SVXqHq23KuU+CMkimeyDLd8z7brIQfud5W2Ru9/PIWrftuU3y+TgKjZR9awC7pT/
dXF8cCwPOa33MEOUAL2syunC/nAf7RDhBeCnWtj0G9wKGXWdnqFlzIaKVr4sO0wQ
RO457ySvXReGkhxe7Df178VQfst9jppCA0FR7m+MlNe8BP31gNEfUvHi0HxYnD4r
lyOXA3ltnhgirKhR070wHOPVbR2ZqWuwe4Qv+QAmwYJup95IU6UsXDBcU5VVHNqa
9U+Mb9+FTfcPkgKX60AHJiWdgMsPvuYIKrNoYPBLexv+x1uYdCTr6iB1YQnHCQee
jyRW8O7NLo/lxDIAJsh0
=5ZQO
-----END PGP SIGNATURE-----