Vincent Povirk wrote:
As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, comparing with native output.
I think it will help. It should be stable as long as we are careful about how strict the tests are. It's probably not as appropriate to be this strict most of the time.
In this particular test, I think we can expect pixel-accuracy. By default there is no antialiasing, and the shape is a rectangle. Similarly, if we draw a raster image at integer coordinates, we should get a consistent result.
In this particular test definitely yes.
Maybe it makes sense to add an antialiasing drawing tests to find out a closer algorithm for line drawing with different SmoothingModes...
I'm still stuck on the question of how we can implement antialiasing while relying so heavily on gdi32.
Here I mean GdipDrawLine, for example, for Graphics with SmoothingMode set. We can use LineTo or antialiasing computing each pixel, it isn't a point. --- P.S. there's no place for todo_wine in you expect_pixel.