Re: remove redundant semicolons for ANSI compat.

[Michael Stefaniuc]

Joel Parker wrote:
> Bug 4527
> > From 205f7fdd9a63409014a322318aba3fd77ec90f47 Mon Sep 17 00:00:00 2001
>
> From: Joel Parker <joeljkp@joel-laptop.(none)>
> Date: Fri, 12 Jan 2007 17:26:47 -0600
> Subject: remove redundant semicolons for ANSI compat.
> @@ -636,17 +636,17 @@ #define DEFINE_SMapLS(n) \
>                       "movl " #n "(%ebp),%eax\n\t" \
>                       "call " __ASM_NAME("SMapLS") "\n\t" \
>                       "movl %edx," #n "(%ebp)\n\t" \
> -
>                 "ret" );
> -
>                 "ret" )
>
> -DEFINE_SMapLS(8);
> -DEFINE_SMapLS(12);
> -DEFINE_SMapLS(16);
> -DEFINE_SMapLS(20);
> -DEFINE_SMapLS(24);
> -DEFINE_SMapLS(28);
> -DEFINE_SMapLS(32);
> -DEFINE_SMapLS(36);
> -DEFINE_SMapLS(40);
> +DEFINE_SMapLS(8)
> +DEFINE_SMapLS(12)
> +DEFINE_SMapLS(16)
> +DEFINE_SMapLS(20)
> +DEFINE_SMapLS(24)
> +DEFINE_SMapLS(28)
> +DEFINE_SMapLS(32)
> +DEFINE_SMapLS(36)
> +DEFINE_SMapLS(40)

Are you sure this compiles? You removed the semicolon in the macro
definition and when it is used. And even if it compiles the code needs
to look like C code.

bye
    michael