Re: [2/8] WineD3D: Catch NOP vertex declaration changes

[H. Verbeet]

On 04/01/07, Christoph Bumiller  wrote:
> Not performing the following:
> if (NULL != pDecl) {
>     IWineD3DVertexDeclaration_AddRef(pDecl);
> }
>
> in IWineD3DDeviceImpl_SetVertexDeclaration(...) when state is being
> recorded (note the return that was added), seems to cause a page fault,
> at least in NFS: Most Wanted. Is it possible that not adding a
> reference here causes the declaration object to be deallocated to
> early, when it is still used by the application ?

Yeah, that'll break refcounts.