On Fri, Mar 23, 2018 at 11:16 PM Carlos Vega García carlosvegagc@gmail.com wrote:
Signed-off-by: Carlos Vega García carlosvegagc@gmail.com
Makefile.in: Makefile for explorer.exe tests (try 3)
Signed-off-by: Carlos Vega García carlosvegagc@gmail.com
Makefile.in: Makefile for explorer.exe tests (try 3)
Signed-off-by: Carlos Vega García carlosvegagc@gmail.com
One Signed-off-by line is enough, and you can just get rid of the comment about Makefile.in.
- /*I use the character 92 = '' because if you write the character
the gcc
* compiler misunderstand it*/
You can (and should) write '\'.
You'll also need to resolve the test failures on various versions of Windows: https://testbot.winehq.org/JobDetails.pl?Key=37113
Finally, please check the spelling and grammar of your patch. There are mistakes in nearly every comment.
-Alex