Re: [PATCH 1/2] msi: Execute the custom action server with the correct bitness.

[Zebediah Figura]

On 30/04/18 13:01, Alexandre Julliard wrote:
> Zebediah Figura  writes:
> > The bitness depends solely on the bitness of the DLL (tested manually).
> >
> > Fixes bugs 31741 and 37856.
> > Signed-off-by: Zebediah Figura
> >
> > dlls/msi/custom.c | 29 +++++++++++++++++++++++++++--
> >  1 file changed, 27 insertions(+), 2 deletions(-)
> >
> > diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
> > index 72c3efd..4ec1a39 100644
> > --- a/dlls/msi/custom.c
> > +++ b/dlls/msi/custom.c
> > @@ -579,11 +579,19 @@ UINT __wine_msi_call_dll_function(const GUID *guid)
> >
> > static DWORD WINAPI DllThread( LPVOID arg )
> >  {
> > - WCHAR buffer[64] = {'m','s','i','e','x','e','c','.','e','x','e',' ','-','E','m','b','e','d','d','i','n','g',' ',0};
> > - static const WCHAR msiexec32W[] = {'C',':','/','w','i','n','d','o','w','s','/',
> > -
> >    's','y','s','w','o','w','6','4','/','m','s','i','e','x','e','c','.','e','x','e',0};
>
> This works, but it would be cleaner to use GetSystemWow64Directory. Also
> you probably want to pass the full path name as the application name in
> CreateProcess.

Thanks; I've sent an updated patch.