Re: [PATCH] winspool.drv: Implement OpenPrinter2.

[Huw Davies]

On 13 Jul 2022, at 09:46, Dmitry Timoshkov  wrote:
> diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c
> index 482f70a2235..c536253317b 100644
> --- a/dlls/winspool.drv/info.c
> +++ b/dlls/winspool.drv/info.c
> @@ -2078,6 +2078,24 @@ BOOL WINAPI OpenPrinterW(LPWSTR lpPrinterName,HANDLE *phPrinter, LPPRINTER_DEFAU
>     return (*phPrinter != 0);
> }
>
> +BOOL WINAPI OpenPrinter2A(LPSTR name, HANDLE *printer,
> - PRINTER_DEFAULTSA *defaults, PRINTER_OPTIONSA *options)
>
> +{
> - if (options)
> -
>    FIXME("flags %08lx ignored\n", options->dwFlags);
> -
> - return OpenPrinterA(name, printer, defaults);
>
> +}
> -
>
> +BOOL WINAPI OpenPrinter2W(LPWSTR name, HANDLE *printer,
> - PRINTER_DEFAULTSW *defaults, PRINTER_OPTIONSW *options)
>
> +{
> - if (options)
> -
>    FIXME("flags %08lx ignored\n", options->dwFlags);
> -
> - return OpenPrinterW(name, printer, defaults);
>
> +}

Could we do this the other way around and have e.g. OpenPrinterW()
call OpenPrinter2W()?  I know that msdn states that OpenPrinter2A()
isn't implemented, but I don't think we need to follow that.

Huw.