Re: [PATCH v4 2/7] mfplat/tests: Use a more unique pattern when testing image formats.

[Nikolay Sivov]

On 6/21/22 14:22, Giovanni Mascellani wrote:
>           case MAKEFOURCC('I','M','C','2'):
>           case MAKEFOURCC('I','M','C','4'):
> -
>            for (j = ptr->height; j < length2 / stride; j++)
> -
>                for (k = 0; k < ptr->width / 2; k++)
> -
>                    ok(data[j * pitch + k] == 0xff, "Unexpected byte %02x at test %d row %d column %d.\n", data[j * pitch + k], i, j, k);
> -
>            for (j = ptr->height; j < length2 / stride; j++)
> -
>                for (k = pitch / 2; k < pitch / 2 + ptr->width / 2; k++)
> -
>                    ok(data[j * pitch + k] == 0xff, "Unexpected byte %02x at test %d row %d column %d.\n", data[j * pitch + k], i, j, k);
> -
>            for (j = 0; j < ptr->height; j++)
> -
>                for (k = 0; k < stride / 2; k++)
> -
>                    todo_if(ptr->height % 2 == 1 && j >= 2)
> -
>                    ok(data[j * (pitch / 2) + k] == (((j + ptr->height) % 16) << 4) + (k % 16),
> -
>                            "Unexpected byte %02x instead of %02x at test %d row %d column %d.\n",
> -
>                            data[j * (pitch / 2) + k], (((j + ptr->height) % 16) << 4) + (k % 16), i, j + ptr->height, k);
>             break;

Should this use todo_wine_if()? I think that's why it fails on the bot.