Re: [PATCH] include: Protect _SECURITY_ATTRIBUTES from being defined twice

[Zebediah Figura (she/her)]

On 1/17/21 3:46 PM, Alistair Leslie-Hughes wrote:
> Signed-off-by: Alistair Leslie-Hughes
>
> include/winbase.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/winbase.h b/include/winbase.h
> index dc8aa081be4..3992c124393 100644
> --- a/include/winbase.h
> +++ b/include/winbase.h
> @@ -232,6 +232,8 @@ typedef struct _OFSTRUCT
>
> #define MAX_COMPUTERNAME_LENGTH    15
>
> +#ifndef _SECURITY_ATTRIBUTES_
> +#define _SECURITY_ATTRIBUTES_
>  /* The security attributes structure */
>  typedef struct _SECURITY_ATTRIBUTES
>  {
> @@ -239,6 +241,7 @@ typedef struct _SECURITY_ATTRIBUTES
>      LPVOID  lpSecurityDescriptor;
>      BOOL  bInheritHandle;
>  } SECURITY_ATTRIBUTES, *PSECURITY_ATTRIBUTES, *LPSECURITY_ATTRIBUTES;
> +#endif
>
> #ifndef _FILETIME_
>  #define _FILETIME_

How can this be defined twice? As far as I can see, it's defined in
winbase.h and wtypes.idl, but the latter only defines it for the IDL
compiler.